[
https://issues.apache.org/jira/browse/ZOOKEEPER-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131490#comment-13131490
]
Hadoop QA commented on ZOOKEEPER-1221:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499835/ZOOKEEPER-1221.patch
against trunk revision 1185994.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/637//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/637//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/637//console
This message is automatically generated.
> Provide accessors for Request.{hdr|txn}
> ---------------------------------------
>
> Key: ZOOKEEPER-1221
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1221
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1221.patch, ZOOKEEPER-1221.patch,
> ZOOKEEPER-1221.patch
>
>
> I'm working on a larger patch that makes the Request class immutable. To see,
> where the hdr and txn fields are modified, it helped to introduce accessor
> methods. The JVM should happily inline the method calls so no performance
> overhead should be expected.
> There's a minor, unrelated change included: ToBeAppliedRequestProcessor had a
> reference to the toBeApplied list of the Leader. So it was hard to find all
> places, where this list was actually modified. The patch gives instead the
> leader instance to the toBeAppliedRequestProcessor and the processor then
> accesses leader.toBeApplied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
