[ https://issues.apache.org/jira/browse/ZOOKEEPER-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139162#comment-13139162 ]
jirapos...@reviews.apache.org commented on ZOOKEEPER-1259: ---------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2610/ ----------------------------------------------------------- Review request for zookeeper. Summary ------- > central mapping from type to txn record class > --------------------------------------------- > > Key: ZOOKEEPER-1259 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1259 > Project: ZooKeeper > Issue Type: Sub-task > Reporter: Thomas Koch > Assignee: Thomas Koch > Attachments: ZOOKEEPER-1259.patch, ZOOKEEPER-1259.patch, > ZOOKEEPER-1259.patch, ZOOKEEPER-1259.patch > > > There are two places where large switch statements do nothing else to get the > correct Record class accorging to a txn type. Provided a static map in > SerializeUtils from type to Class<? extends Record> and a method to retrieve > a new txn Record instance for a type. > Code size reduced by 28 lines. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira