[
https://issues.apache.org/jira/browse/ZOOKEEPER-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139174#comment-13139174
]
Hadoop QA commented on ZOOKEEPER-1259:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501439/ZOOKEEPER-1259.patch
against trunk revision 1190450.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/728//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/728//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/728//console
This message is automatically generated.
> central mapping from type to txn record class
> ---------------------------------------------
>
> Key: ZOOKEEPER-1259
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1259
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1259.patch, ZOOKEEPER-1259.patch,
> ZOOKEEPER-1259.patch, ZOOKEEPER-1259.patch
>
>
> There are two places where large switch statements do nothing else to get the
> correct Record class accorging to a txn type. Provided a static map in
> SerializeUtils from type to Class<? extends Record> and a method to retrieve
> a new txn Record instance for a type.
> Code size reduced by 28 lines.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
