[
https://issues.apache.org/jira/browse/ZOOKEEPER-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149133#comment-13149133
]
Hadoop QA commented on ZOOKEEPER-1239:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503499/ZOOKEEPER-1239_br34.patch
against trunk revision 1201045.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/789//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/789//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/789//console
This message is automatically generated.
> add logging/stats to identify fsync stalls
> ------------------------------------------
>
> Key: ZOOKEEPER-1239
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1239
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.4, 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1239_br33.patch, ZOOKEEPER-1239_br34.patch
>
>
> We don't have any logging to identify fsync stalls. It's a somewhat common
> occurrence (after gc/swap issues) when trying to diagnose pipeline stalls -
> where outstanding requests start piling up and operational latency increases.
> We should have some sort of logging around this. e.g. if the fsync time
> exceeds some limit then log a warning, something like that.
> It would also be useful to publish "stat" information related to this.
> min/avg/max latency for fsync.
> This should also be exposed through JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
