[ https://issues.apache.org/jira/browse/ZOOKEEPER-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179411#comment-13179411 ]
Hudson commented on ZOOKEEPER-1343: ----------------------------------- Integrated in ZooKeeper-trunk #1417 (See [https://builds.apache.org/job/ZooKeeper-trunk/1417/]) ZOOKEEPER-1343. getEpochToPropose should check if lastAcceptedEpoch is greater or equal than epoch breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1227000 Files : * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java > getEpochToPropose should check if lastAcceptedEpoch is greater or equal than > epoch > ---------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1343 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.0 > Reporter: Flavio Junqueira > Assignee: Flavio Junqueira > Priority: Critical > Fix For: 3.5.0, 3.4.3 > > Attachments: ZOOKEEPER-1343-3.4.patch, ZOOKEEPER-1343.patch, > ZOOKEEPER-1343.patch, ZOOKEEPER-1343.patch > > > The following block in Leader.getEpochToPropose: > {noformat} > if (lastAcceptedEpoch > epoch) { > epoch = lastAcceptedEpoch+1; > } > {noformat} > needs to be fixed, since it doesn't increment the epoch variable in the case > epoch != -1 (initial value) and lastAcceptedEpoch is equal. The fix trivial > and corresponds to changing > with >=. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira