[ https://issues.apache.org/jira/browse/ZOOKEEPER-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182895#comment-13182895 ]
Flavio Junqueira commented on ZOOKEEPER-1343: --------------------------------------------- Hi Alex, I'd like to suggest that we create a new jira for the issue you're raising, especially if it is happening in your branch, and not in trunk. We may want to look more carefully into it before rushing into a fix. Otherwise, your observations make sense. > getEpochToPropose should check if lastAcceptedEpoch is greater or equal than > epoch > ---------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1343 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.0 > Reporter: Flavio Junqueira > Assignee: Flavio Junqueira > Priority: Critical > Fix For: 3.4.3, 3.5.0 > > Attachments: ZOOKEEPER-1343-3.4.patch, ZOOKEEPER-1343.patch, > ZOOKEEPER-1343.patch, ZOOKEEPER-1343.patch > > > The following block in Leader.getEpochToPropose: > {noformat} > if (lastAcceptedEpoch > epoch) { > epoch = lastAcceptedEpoch+1; > } > {noformat} > needs to be fixed, since it doesn't increment the epoch variable in the case > epoch != -1 (initial value) and lastAcceptedEpoch is equal. The fix trivial > and corresponds to changing > with >=. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira