[
https://issues.apache.org/jira/browse/ZOOKEEPER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181100#comment-13181100
]
[email protected] commented on ZOOKEEPER-1350:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3410/
-----------------------------------------------------------
(Updated 2012-01-06 04:59:53.911307)
Review request for zookeeper.
Summary (updated)
-------
LearnerZooKeeperServer has no option to disable JMX registrations. Curator has
a test ZK server cluster. Due to the intricacies of JMX, the registrations
cannot be easily undone. In order for the Curator Test cluster to be re-usable
in a testing session, JavaAssist ugliness was necessary to make
LearnerZooKeeperServer.registerJMX() and LearnerZooKeeperServer.unregisterJMX()
NOPs.
This addresses bug ZOOKEEPER-1350.
https://issues.apache.org/jira/browse/ZOOKEEPER-1350
Diffs
-----
Diff: https://reviews.apache.org/r/3410/diff
Testing
-------
Thanks,
Jordan
> Please make JMX registration optional in LearnerZooKeeperServer
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Attachments: jmx_optional.diff, patch.txt
>
>
> LearnerZooKeeperServer has no option to disable JMX registrations. Curator
> has a test ZK server cluster. Due to the intricacies of JMX, the
> registrations cannot be easily undone. In order for the Curator Test cluster
> to be re-usable in a testing session, JavaAssist ugliness was necessary to
> make LearnerZooKeeperServer.registerJMX() and
> LearnerZooKeeperServer.unregisterJMX() NOPs.
> I suggest a simple System property.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
