[
https://issues.apache.org/jira/browse/ZOOKEEPER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181117#comment-13181117
]
Hadoop QA commented on ZOOKEEPER-1350:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509655/patch.txt
against trunk revision 1227927.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/882//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/882//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/882//console
This message is automatically generated.
> Please make JMX registration optional in LearnerZooKeeperServer
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Attachments: jmx_optional.diff, patch.txt
>
>
> LearnerZooKeeperServer has no option to disable JMX registrations. Curator
> has a test ZK server cluster. Due to the intricacies of JMX, the
> registrations cannot be easily undone. In order for the Curator Test cluster
> to be re-usable in a testing session, JavaAssist ugliness was necessary to
> make LearnerZooKeeperServer.registerJMX() and
> LearnerZooKeeperServer.unregisterJMX() NOPs.
> I suggest a simple System property.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
