----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3631/#review4597 -----------------------------------------------------------
conf/zoo_sample.cfg <https://reviews.apache.org/r/3631/#comment10246> Redundant 'to ' in the beginning. src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java <https://reviews.apache.org/r/3631/#comment10247> Does this (classname) match the entry in zoo_sample.cfg ? src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java <https://reviews.apache.org/r/3631/#comment10248> Indentation is different from existing code. - Ted On 2012-01-25 18:56:42, Eugene Koontz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3631/ > ----------------------------------------------------------- > > (Updated 2012-01-25 18:56:42) > > > Review request for zookeeper. > > > Summary > ------- > > ZOOKEEPER-1373: Hardcoded SASL login context name clashes with Hadoop > security configuration override > > Fix is to allow system property to designate the JAAS configuration section > that the zookeeper client will use. > > > This addresses bug ZOOKEEPER-1373. > https://issues.apache.org/jira/browse/ZOOKEEPER-1373 > > > Diffs > ----- > > conf/zoo_sample.cfg aafb324 > src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40 > src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e > src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedClientTest.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/test/SaslAuthFailDesignatedClientTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3631/diff > > > Testing > ------- > > "ant test" java tests pass. > > > Thanks, > > Eugene > >
