> On 2012-01-25 21:56:22, Thomas wrote: > > src/java/main/org/apache/zookeeper/ClientCnxn.java, line 950 > > <https://reviews.apache.org/r/3631/diff/2/?file=70795#file70795line950> > > > > SASL connection also needs to be attempted when > > ZooKeeperSaslClient.LOGIN_CONTEXT_NAME_KEY is set as system property and > > java.security.auth.login.config is not set (that's what happens with Hadoop > > security). That was part of my patch. > >
Hi Thomas, Sorry, I should have addressed your use case (no JAAS configuration file because using Hadoop security JAAS configuration). I made the properties-checking more elaborate - please see if my latest patch matches your intent. I tried to make the code guess the user's intentions regarding SASL configuration and give diagnostic log messages in case of failure. I also added another test for a missing Login Context section (please see SaslAuthMissingClientConfigTest.java). - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3631/#review4606 ----------------------------------------------------------- On 2012-01-26 00:30:39, Eugene Koontz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3631/ > ----------------------------------------------------------- > > (Updated 2012-01-26 00:30:39) > > > Review request for zookeeper. > > > Summary > ------- > > ZOOKEEPER-1373: Hardcoded SASL login context name clashes with Hadoop > security configuration override > > Fix is to allow system property to designate the JAAS configuration section > that the zookeeper client will use. > > > This addresses bug ZOOKEEPER-1373. > https://issues.apache.org/jira/browse/ZOOKEEPER-1373 > > > Diffs > ----- > > > src/java/test/org/apache/zookeeper/test/SaslAuthFailDesignatedClientTest.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/test/SaslAuthMissingClientConfigTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedClientTest.java > PRE-CREATION > src/java/main/org/apache/zookeeper/Login.java 6d2a38c > src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e > conf/zoo_sample.cfg aafb324 > src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40 > > Diff: https://reviews.apache.org/r/3631/diff > > > Testing > ------- > > "ant test" java tests pass. > > > Thanks, > > Eugene > >
