On Sat, Jan 21, 2012 at 1:02 AM, Flavio Junqueira <f...@yahoo-inc.com> wrote: > I like the idea of a github repository to share code changes in progress. > Pat has also pointed it out offline.
I personally use git (and github) and it works well for me. However my concern in this case is that if we don't integrate directly into the trunk there's a chance it will get orphaned. Not fair for Alex, plus we miss out on the functionality. I'd rather see a number of smaller patches that are easy to review, verify and test committed to trunk. In no case do I want to see a big patch or a single merge from some branch (svn, git or otw). All changes must ensure backward compatibility. See what Todd did here for a great example of how a large refactoring was handled (relatively) recently in hdfs: https://issues.apache.org/jira/browse/HDFS-1073 Given this is an optional feature it's not high risk (if it's broken don't use it). Although there's quite a bit of debt built up in the code, a major concern of mine is that we'll break existing functionality in some subtle way and miss it. Patrick