[
https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271832#comment-13271832
]
Patrick Hunt commented on ZOOKEEPER-1437:
-----------------------------------------
I don't think we should have the "requires auth" check. We should guarantee
order. That seems dangerous to me for a couple reasons. Was there a reason you
added it?
I'd also suggest that you latch the "in progress" indicator so that you don't
need to constantly call that method. ie three states "sasl auth pending" in
which you still have to check, vs "sasl auth completed" /"no sasl auth" in
which case you don't.
One concern is that we'll hog the cpu in this case. what I mean is. if sasl is
in progress, and we just return out of doio, the "write interest" is still set.
So the OS select will wake up immediately to allow us to write, which we won't
do (still waiting), etc.... Not sure how to address that (or if it's really a
problem), need to look at it a bit more. What do you think though?
> Client uses session before SASL authentication complete
> -------------------------------------------------------
>
> Key: ZOOKEEPER-1437
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.4.3
> Reporter: Thomas Weise
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch
>
>
> Found issue in the context of hbase region server startup, but can be
> reproduced w/ zkCli alone.
> getData may occur prior to SaslAuthenticated and fail with NoAuth. This is
> not expected behavior when the client is configured to use SASL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
