[
https://issues.apache.org/jira/browse/ZOOKEEPER-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467251#comment-13467251
]
Hadoop QA commented on ZOOKEEPER-721:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12547281/ZOOKEEPER-721.patch
against trunk revision 1391526.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1201//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1201//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1201//console
This message is automatically generated.
> No <exclusions> set for log4j dependency in the generated pom.xml
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-721
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-721
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.3.0
> Reporter: Paolo Castagna
> Priority: Minor
> Labels: ivy, maven
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-721.patch
>
>
> The generated Maven pom.xml file contains:
> {code}
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.15</version>
> <scope>compile</scope>
> </dependency>
> {code}
> It would be better to have:
> {code}
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.15</version>
> <scope>compile</scope>
> <exclusions>
> <exclusion>
> <groupId>javax.jms</groupId>
> <artifactId>jms</artifactId>
> </exclusion>
> <exclusion>
> <groupId>com.sun.jdmk</groupId>
> <artifactId>jmxtools</artifactId>
> </exclusion>
> <exclusion>
> <groupId>com.sun.jmx</groupId>
> <artifactId>jmxri</artifactId>
> </exclusion>
> <exclusion>
> <groupId>javax.mail</groupId>
> <artifactId>mail</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> {code}
> This would avoid to people depending on ZooKeeper artifacts the pain to
> exclude such "broken" dependencies by themselves.
> A similar issue is discussed in HADOOP-6629, although I am not clear on how
> to solve fix it using Ivy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
