[
https://issues.apache.org/jira/browse/ZOOKEEPER-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467267#comment-13467267
]
Sean Busbey commented on ZOOKEEPER-721:
---------------------------------------
Note to reviewer: there are no new or modified tests because the change is just
a license file and part of the configuration for findbugs.
You can verify the findbugs change by running the findbugs target and watching
the number of unknown classes go down. (See also ZOOKEEPER-1553 for a fix to
the general problem of findbugs not knowing about classes)
> No <exclusions> set for log4j dependency in the generated pom.xml
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-721
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-721
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.3.0
> Reporter: Paolo Castagna
> Priority: Minor
> Labels: ivy, maven
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-721.patch
>
>
> The generated Maven pom.xml file contains:
> {code}
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.15</version>
> <scope>compile</scope>
> </dependency>
> {code}
> It would be better to have:
> {code}
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.15</version>
> <scope>compile</scope>
> <exclusions>
> <exclusion>
> <groupId>javax.jms</groupId>
> <artifactId>jms</artifactId>
> </exclusion>
> <exclusion>
> <groupId>com.sun.jdmk</groupId>
> <artifactId>jmxtools</artifactId>
> </exclusion>
> <exclusion>
> <groupId>com.sun.jmx</groupId>
> <artifactId>jmxri</artifactId>
> </exclusion>
> <exclusion>
> <groupId>javax.mail</groupId>
> <artifactId>mail</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> {code}
> This would avoid to people depending on ZooKeeper artifacts the pain to
> exclude such "broken" dependencies by themselves.
> A similar issue is discussed in HADOOP-6629, although I am not clear on how
> to solve fix it using Ivy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
