[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560733#comment-13560733
 ] 

lixiaofeng commented on ZOOKEEPER-1606:
---------------------------------------

There seems to be a contradiction between the comment and the code.
        //find out who is the leader and kill it
        if ( qb.s5.getPeerState() != ServerState.LEADING) {
            throw new Exception("the last server is not the leader");
        }
I'm new here so there may be a very good reason that I'm not aware of that the 
last server will be the leader. But the comment clearly says differently, 
stating the code below intend to find out who is the leader. Isn't it supposed 
to be s5 all the time? According to the code.
                
> intermittent failures in ZkDatabaseCorruptionTest on jenkins
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1606
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1606
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0, 3.4.5
>            Reporter: Patrick Hunt
>             Fix For: 3.5.0, 3.4.6
>
>
> ZkDatabaseCorruptionTest is failing intermittently on jenkins with:
> "Error Message: the last server is not the leader"
> Seeing this on jdk7/openjdk7/solaris - 3 times in the last month.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-openjdk7/2/testReport/junit/org.apache.zookeeper.test/ZkDatabaseCorruptionTest/testCorruption/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to