[
https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770626#comment-13770626
]
Hadoop QA commented on ZOOKEEPER-1096:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12603793/ZOOKEEPER-1096.patch
against trunk revision 1524275.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1586//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1586//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1586//console
This message is automatically generated.
> Leader communication should listen on specified IP, not wildcard address
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3, 3.4.0
> Reporter: Jared Cantwell
> Assignee: Jared Cantwell
> Priority: Minor
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1096_branch3.4.patch,
> ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096_branch3.4.patch,
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch,
> ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch
>
>
> Server should specify the local address that is used for leader communication
> and leader election (and not use the default of listening on all interfaces).
> This is similar to the clientPortAddress parameter that was added a year
> ago. After reviewing the code, we can't think of a reason why only the port
> would be used with the wildcard interface, when servers are already
> connecting specifically to that interface anyway.
> I have submitted a patch, but it does not account for all leader election
> algorithms.
> Probably should have an option to toggle this, for backwards compatibility,
> although it seems like it would be a bug if this change broke things.
> There is some more information about making it an option here:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%[email protected]%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
