[ https://issues.apache.org/jira/browse/ZOOKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778662#comment-13778662 ]
Hudson commented on ZOOKEEPER-1096: ----------------------------------- SUCCESS: Integrated in ZooKeeper-trunk #2068 (See [https://builds.apache.org/job/ZooKeeper-trunk/2068/]) ZOOKEEPER-1096. Leader communication should listen on specified IP, not wildcard address (Jared Cantwell, German Blanco via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526317) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java > Leader communication should listen on specified IP, not wildcard address > ------------------------------------------------------------------------ > > Key: ZOOKEEPER-1096 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1096 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.3.3, 3.4.0 > Reporter: Jared Cantwell > Assignee: Germán Blanco > Priority: Minor > Fix For: 3.5.0, 3.4.6 > > Attachments: ZOOKEEPER-1096_branch3.4.patch, > ZOOKEEPER-1096_branch3.4.patch, ZOOKEEPER-1096_branch3.4.patch, > ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch, > ZOOKEEPER-1096.patch, ZOOKEEPER-1096.patch > > > Server should specify the local address that is used for leader communication > and leader election (and not use the default of listening on all interfaces). > This is similar to the clientPortAddress parameter that was added a year > ago. After reviewing the code, we can't think of a reason why only the port > would be used with the wildcard interface, when servers are already > connecting specifically to that interface anyway. > I have submitted a patch, but it does not account for all leader election > algorithms. > Probably should have an option to toggle this, for backwards compatibility, > although it seems like it would be a bug if this change broke things. > There is some more information about making it an option here: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=h2+7gnj_4p28hgcxjh345h...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira