[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778179#comment-13778179
 ] 

Flavio Junqueira commented on ZOOKEEPER-87:
-------------------------------------------

Here are a few comments, German:

# Please make the initialization of SyncLimitCheck fields explicit.
# Please add blank lines between method definitions 
(http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html#487)
# The test case does not fail for me when I only apply the test case changes. I 
haven't looked too closely into it to determine the reason, but I was wondering 
if it fails for you.
                
> Follower does not shut itself down if its too far behind the leader.
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-87
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-87
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.5.0, 3.4.5
>            Reporter: Mahadev konar
>            Assignee: Germán Blanco
>            Priority: Critical
>              Labels: patch
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-87_3.4.patch, ZOOKEEPER-87.patch
>
>
> Currently, the follower if lagging behind keeps sending pings to the leader 
> it will stay alive and will keep getting further and further behind the 
> leader. The follower should shut itself down if it is not able to keep up to 
> the leader within some limit so that gurantee of updates can be made to the 
> clients connected to different servers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to