[ https://issues.apache.org/jira/browse/ZOOKEEPER-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789799#comment-13789799 ]
Raul Gutierrez Segales commented on ZOOKEEPER-1784: --------------------------------------------------- [~shralex]: so that code path, processing INFORMANDACTIVATE, doesn't have (it seems) a corresponding test case. Should we add one or extend an existing one to cover it? > Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus > ------------------------------------------------------------------------ > > Key: ZOOKEEPER-1784 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1784 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.5.0 > Reporter: Raul Gutierrez Segales > Assignee: Raul Gutierrez Segales > Attachments: ZOOKEEPER-1784.patch > > > If you look at Learner#syncWithLeader: > {noformat} > while (self.isRunning()) { > readPacket(qp); > switch(qp.getType()) { > ....... > case Leader.INFORM: > case Leader.INFORMANDACTIVATE: > PacketInFlight packet = new PacketInFlight(); > packet.hdr = new TxnHeader(); > if (qp.getType() == Leader.COMMITANDACTIVATE) { > {noformat} > I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read > "qp.getType() == Leader.INFORMANDACTIVATE". > Assigning to Alexander for now since this is part of ZOOKEEPER-107. -- This message was sent by Atlassian JIRA (v6.1#6144)