[
https://issues.apache.org/jira/browse/ZOOKEEPER-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789819#comment-13789819
]
Alexander Shraer commented on ZOOKEEPER-1784:
---------------------------------------------
I actually was just looking at this.
The reconfig tests apparently are not testing the COMMITANDACTIVATE or
OBSERVEANDACTIVATE paths in syncwithleader currently (I had a test where a
server misses a reconfig and learns about it later but apparently its not
through this code path). The only test that I see using the INFORMANDACTIVATE
path is Zab1_0Test (testNormalObserverRun) For the COMMITANDACTIVATE its
FollowerResyncConcurrencyTest, QuorumTest and Zab1_0Test
We should try to understand how the tests above are activating these paths.
> Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1784
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Attachments: ZOOKEEPER-1784.patch
>
>
> If you look at Learner#syncWithLeader:
> {noformat}
> while (self.isRunning()) {
> readPacket(qp);
> switch(qp.getType()) {
> .......
> case Leader.INFORM:
> case Leader.INFORMANDACTIVATE:
> PacketInFlight packet = new PacketInFlight();
> packet.hdr = new TxnHeader();
> if (qp.getType() == Leader.COMMITANDACTIVATE) {
> {noformat}
> I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read
> "qp.getType() == Leader.INFORMANDACTIVATE".
> Assigning to Alexander for now since this is part of ZOOKEEPER-107.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
