[
https://issues.apache.org/jira/browse/ZOOKEEPER-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810441#comment-13810441
]
Raul Gutierrez Segales commented on ZOOKEEPER-1805:
---------------------------------------------------
2nd test looks fine to me as well. I guess you could DRY it up a bit by having:
{noformat}
HashMap<Long, Vote> getVotes(long a, long b) {
HashMap<Long, Vote> votes = new HashMap<Long, Vote>();
votes.put(0L, new Vote(4L, Vote.DONTCARE, Vote.DONTCARE, a,
ServerState.FOLLOWING));
votes.put(1L, new Vote(4L, Vote.DONTCARE, Vote.DONTCARE, a,
ServerState.FOLLOWING));
votes.put(3L, new Vote(4L, 10L, 10L, b, ServerState.FOLLOWING));
votes.put(4L, new Vote(4L, 10L, 10L, b, ServerState.LEADING));
return votes;
}
{noformat}
but I guess copy/pasta is alright in test cases for readability (though I
rather DRY it). Thanks [~fpj].
> "Don't care" value in ZooKeeper election breaks rolling upgrades
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-1805
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1805
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Blocker
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch,
> ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch
>
>
> This is an issue that has been originally reported in ZOOKEEPER-1732.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
