[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812480#comment-13812480
 ] 

Flavio Junqueira commented on ZOOKEEPER-1805:
---------------------------------------------

bq. The don't care values never get sent over the network

How do you think we prevent don't care values to go over the network? I think 
they get inserted in election notifications and sent just the same.

bq.  All votes in the outofelection collection have don't care values

This is not necessarily the case when performing a rolling upgrade because we 
can have a mix of servers with and without ZOOKEEPER-1732.

bq. The same result would have been achieved by setting the epoch to the don't 
care value

The patch I proposed should only allow different epoch values if the there is a 
mix of don't care and regular values. Also, when two notifications n and n' are 
being compared (Vote.equals), n has don't care values and n' doesn't, it also 
makes sure that the epoch in n is at least as large as the one in n'. It 
doesn't sound like this achieves the same effect as your proposal, no?



> "Don't care" value in ZooKeeper election breaks rolling upgrades
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1805
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1805
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Blocker
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1805-b3.4.patch, ZOOKEEPER-1805.patch, 
> ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, 
> ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch, ZOOKEEPER-1805.patch
>
>
> This is an issue that has been originally reported in ZOOKEEPER-1732.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to