[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827721#comment-13827721 ]
Germán Blanco commented on ZOOKEEPER-1817: ------------------------------------------ Just one additional comment ... I think that in this line: {noformat} public class QuorumMaj implements QuorumVerifier { + private static final Logger LOG = LoggerFactory.getLogger(QuorumVerifier.class); + {noformat} It should be QuorumMaj.class instead of QuorumVerifier.class In terms of behavior, this has a "+1" from me. I will still repeat the tests again in the last version of the patch, just in case. Thank you for the great work on this [~fpj]! > Fix don't care for b3.4 > ----------------------- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task > Reporter: Flavio Junqueira > Assignee: Flavio Junqueira > Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)