[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829923#comment-13829923
]
Flavio Junqueira commented on ZOOKEEPER-1817:
---------------------------------------------
Thanks for bringing this up, you're right. The current predicate works for
versions 0x0 and 0x1, but it doesn't seem to do it right moving forward. There
is a caveat to it, however. I was thinking of removing the backward
compatibility code we have introduce here for 3.5.0 or even 3.4.7 if we have
it. The transition path for upgrading from say 3.4.5 to 3.5.0 would have to be
through 3.4.6.
I can make the change you suggest, and it is probably a better idea to make it
more general just in case, but my thinking is that this code for backward
compatibility should be gone soon. My sense is that we have quite a number of
bugs because we have to keep introducing complicated logic to satisfy backward
compatibility, so I'd like to try to remove it for future releases. Does it
make sense to you?
> Fix don't care for b3.4
> -----------------------
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
