[
https://issues.apache.org/jira/browse/ZOOKEEPER-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852705#comment-13852705
]
Rakesh R commented on ZOOKEEPER-1844:
-------------------------------------
Thanks for looking at the analysis. Sorry for the delay as am busy with
internal schedules, actually the test case is failing in the trunk for the
following reason.
ZKDatabase#getProposalsFromTxnLog is not closing the iterator which had opened.
I prepared initial draft patch to understand the problem.
[~michim] Could you please apply in your env and see the test case is passing
consistently.
{code}
itr = snapLog.readTxnLog(startZxid, false);
{code}
Also, in the patch I kept iterator closure inside
TxnLogProposalIterator#remove, becuase I failed to find better way to close the
iterator:(. Alternate apporach I'm thinking is instanceof check and implement
TxnLogProposalIterator#close api, but this also feel not good.
{code}
if (txnLogItr instanceof TxnLogProposalIterator) {
{code}
> TruncateTest fails on windows
> -----------------------------
>
> Key: ZOOKEEPER-1844
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1844
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Environment: windows
> Reporter: Michi Mutsuzaki
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1844.patch, ZOOKEEPER-1844.patch
>
>
> TruncateTest has been failing consistently on windows:
> https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/627/testReport/junit/org.apache.zookeeper.test/TruncateTest/testTruncate/
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
