[
https://issues.apache.org/jira/browse/ZOOKEEPER-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853183#comment-13853183
]
Rakesh R commented on ZOOKEEPER-1844:
-------------------------------------
Hi [~fpj], [~michim], [~phunt],
Actually I've observed the following two cases:
# FileTxnLog.java - 'logStream' is not getting closed after the rollover. I
have seen it is not affecting anywhere, because there is 'streamsToFlush'
collection in place, which will be closed always. I think logStream#closure is
good to have kind of. In my patch I didn't included this change and after the
discussion if required will modify the patch with 'logStream#close'.
# FileTxnIterator is keeping PositionInputStream reference and is not closed
properly in many places.
As [~michim] mentioned earlier, the test case is failing only in trunk, but
this is an issue for 3.4.6 as well. IMHO, FileTxnIterator closure needs
improvement in both 3.4 branch as well as trunk.
> TruncateTest fails on windows
> -----------------------------
>
> Key: ZOOKEEPER-1844
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1844
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Environment: windows
> Reporter: Michi Mutsuzaki
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1844.patch, ZOOKEEPER-1844.patch,
> ZOOKEEPER-1844.patch
>
>
> TruncateTest has been failing consistently on windows:
> https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/627/testReport/junit/org.apache.zookeeper.test/TruncateTest/testTruncate/
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
