[
https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875309#comment-13875309
]
Patrick Hunt commented on ZOOKEEPER-442:
----------------------------------------
My code review looks good. Great job - including the number/scope of the tests!
Actually the tests is where I saw my only nit feedback, the user of small
values for SESSION_TIME_OUT and TIME_OUT will result in similar issues as I
recently raised re slow/underprovisioned hardware. I'd suggest you increase
these (see the existing tests, they typically use
org.apache.zookeeper.test.ClientBase.CONNECTION_TIMEOUT).
If you submit a patch to address the timeout I'm +1 and ready to commit.
> need a way to remove watches that are no longer of interest
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-442
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client, server
> Reporter: Benjamin Reed
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: Remove Watch API.pdf, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch
>
>
> currently the only way a watch cleared is to trigger it. we need a way to
> enumerate the outstanding watch objects, find watch events the objects are
> watching for, and remove interests in an event.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
