[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876183#comment-13876183 ]
Rakesh R commented on ZOOKEEPER-442: ------------------------------------ Sorry for the delay, I was travelling last few days. Thanks Raul/Patrick for the reviews. I have updated the patch by using the CONNECTION_TIMEOUT. TIME_OUT is operation timeout and now in latest patch it is CONNECTION_TIMEOUT/5. How the operation timeout is being used in the tests: For example: case #1 : Say user is expecting to remove only WatcherType.Children type. Now will wait for CONNECTION_TIMEOUT/5 to see the result of the removal operation. case #2 : Say user is expecting to remove only WatcherType.Children type. Now after seeing successful removal of child watches, test is waiting for CONNECTION_TIMEOUT/5. After timeout test will verify that whether the call didn't touch any of the Data/Exists watches. If I increase this to a high value will affect the test execution time. Are you agreeing to keep operation timeout as CONNECTION_TIMEOUT/5 milliseconds? > need a way to remove watches that are no longer of interest > ----------------------------------------------------------- > > Key: ZOOKEEPER-442 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442 > Project: ZooKeeper > Issue Type: Sub-task > Components: java client, server > Reporter: Benjamin Reed > Assignee: Rakesh R > Priority: Critical > Fix For: 3.5.0 > > Attachments: Remove Watch API.pdf, ZOOKEEPER-442.patch, > ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, > ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, > ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, > ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, > ZOOKEEPER-442.patch, ZOOKEEPER-442.patch > > > currently the only way a watch cleared is to trigger it. we need a way to > enumerate the outstanding watch objects, find watch events the objects are > watching for, and remove interests in an event. -- This message was sent by Atlassian JIRA (v6.1.5#6160)