[
https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958625#comment-13958625
]
Roy Sindre Norangshol commented on ZOOKEEPER-1371:
--------------------------------------------------
[~calvarez] It's your patch, I'm unsure why you want the junit.run.nolog4j
goal, it simply tries to only run the tests : «<include
name="**/*${test.category}NoLog4j*.java"/>» which is no test files basically
atm. I don't see why we would want to encourage users/devs to particular create
such tests? So maybe it should be removed?
[~fournc]: Can you confirm with packager that it is okey to drop log4j jar file
from distribution? I see no reason for why you want it included in distribution
as it then will land in classpath for users and that complicates things when
they want to choose their own slf4j implementation for logging. I think it
would be enough to have it declared as a test dependency in ivy for the
log4j»-specific test implementations we have. This should be enough for
developers I guess, maybe leave it as a note in a «readme.developers» if they
want to run the jmx log4j test, they should fetch dependencies with ivy to
ensure to get slf4j-log4j12 bridge for running it.
I guess it would make more sense to have the nolog4j goal to exclude the jmx
log4j test instead, make it the default target for running tests and add a note
in «readme.developers» to run «ant junit.run» to include tests which depends on
log4j and then make CI to run the ant junit.run goal.
jmx log4j test is also an integration/system test as well, and most useful to
be run by a CI.
> Remove dependency on log4j in the source code.
> ----------------------------------------------
>
> Key: ZOOKEEPER-1371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3
> Reporter: Mahadev konar
> Assignee: César Álvarez Núñez
> Labels: patch
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch,
> ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch
>
>
> ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We
> should remove the dependency on log4j so that we can make logging pluggable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
