[
https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959342#comment-13959342
]
Michi Mutsuzaki commented on ZOOKEEPER-1371:
--------------------------------------------
I think it's fine to remove the log4j jar file, but at least the documentation
needs to be updated. The commands shown in the documentation uses the log4j jar
file included in the distribution. Maybe we can address this in a separate jira
to get this one checked in?
As for the testing, my personal preference is to *not* exclude the jmx log4j
tests. Ideally running "ant test" should run the same set of tests it did
before this patch. Either that or modify the test so that it doesn't depend on
log4j.
> Remove dependency on log4j in the source code.
> ----------------------------------------------
>
> Key: ZOOKEEPER-1371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3
> Reporter: Mahadev konar
> Assignee: César Álvarez Núñez
> Labels: patch
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch,
> ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch
>
>
> ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We
> should remove the dependency on log4j so that we can make logging pluggable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
