----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/ -----------------------------------------------------------
(Updated May 28, 2014, 12:26 p.m.) Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier. Changes ------- Attached new patch addressing Raul's comments Bugs: ZOOKEEPER-1907 https://issues.apache.org/jira/browse/ZOOKEEPER-1907 Repository: zookeeper Description ------- Improve the thread handling mechanism by detecting if any of the critical thread dies. Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread. Diffs (updated) ----- ./src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/RequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/ServerConfig.java 1597987 ./src/java/main/org/apache/zookeeper/server/SessionTracker.java 1597987 ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1597987 ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/UnimplementedRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1597987 ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1597987 ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/AckRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1597987 ./src/java/main/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java 1597987 ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 1597987 ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerTest.java 1597987 ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1597987 Diff: https://reviews.apache.org/r/20071/diff/ Testing ------- yet to be inlcuded Thanks, Rakesh R