> On April 8, 2014, 6:52 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 1062 > > <https://reviews.apache.org/r/20071/diff/1/?file=550386#file550386line1062> > > > > I think we can do more here.. i.e.: actually find out what thread is > > not running and print that out? We can either go over all threads and check > > or we can have isRunning throw something like CriticalThreadNotRunning() or > > such? > > > > Rakesh R wrote: > Thanks Raul for this comment. I'm confused how to efficiently print out > if multiple thread dies together ?. One more thing I'd like to add is, each > thread have their own exit message in run() method for example, > LOG.info("SyncRequestProcessor exited!"); > In that way I think admin can atleast pinpoint the reason. Does this make > sense to you ?
Somehow I lost sight of this review, so sorry for the delay. Yes that makes total sense! - Raul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review39812 ----------------------------------------------------------- On May 28, 2014, 12:26 p.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20071/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 12:26 p.m.) > > > Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille > Fournier. > > > Bugs: ZOOKEEPER-1907 > https://issues.apache.org/jira/browse/ZOOKEEPER-1907 > > > Repository: zookeeper > > > Description > ------- > > Improve the thread handling mechanism by detecting if any of the critical > thread dies. > Here the idea is to periodically checking the status of all the critical > threads in ZK server using DeathWatcherThread. > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/RequestProcessor.java 1597987 > ./src/java/main/org/apache/zookeeper/server/ServerConfig.java 1597987 > ./src/java/main/org/apache/zookeeper/server/SessionTracker.java 1597987 > ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1597987 > ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/UnimplementedRequestProcessor.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1597987 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/quorum/AckRequestProcessor.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderRequestProcessor.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1597987 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1597987 > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java > 1597987 > > ./src/java/main/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java > 1597987 > ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java > 1597987 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerTest.java > 1597987 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1597987 > > Diff: https://reviews.apache.org/r/20071/diff/ > > > Testing > ------- > > yet to be inlcuded > > > Thanks, > > Rakesh R > >
