[
https://issues.apache.org/jira/browse/ZOOKEEPER-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039923#comment-14039923
]
Hongchao Deng commented on ZOOKEEPER-1746:
------------------------------------------
I submitted a patch for "trunk" branch:
1. add docs for async callbacks.
2. fulfill test coverage as with docs.
3. fix previous test, e.g.:
public void testAsyncGetChildren2Empty() {
- new ChildrenCB(zk).verifyGetChildrenEmpty();
+ new Children2CB(zk).verifyGetChildrenEmpty();
}
One question: does "branch-3.4" need to be patched as well or just backported?
> AsyncCallback.*Callback don't have any Javadoc
> ----------------------------------------------
>
> Key: ZOOKEEPER-1746
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1746
> Project: ZooKeeper
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 3.4.6
> Reporter: Tsuyoshi OZAWA
> Assignee: Hongchao Deng
> Labels: newbie
> Fix For: 3.4.7, 3.5.0
>
> Attachments: ZOOKEEPER-1746.patch
>
>
> AsyncCallback.*Callback don't have any Javadoc. This forces users to read
> source code or sample code to understand what their arguments stand for or
> how one is difference from the others.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
