[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039928#comment-14039928
 ] 

Hadoop QA commented on ZOOKEEPER-1746:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12651828/ZOOKEEPER-1746.patch
  against trunk revision 1601516.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2140//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2140//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2140//console

This message is automatically generated.

> AsyncCallback.*Callback don't have any Javadoc
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-1746
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1746
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 3.4.6
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Hongchao Deng
>              Labels: newbie
>             Fix For: 3.4.7, 3.5.0
>
>         Attachments: ZOOKEEPER-1746.patch
>
>
> AsyncCallback.*Callback don't have any Javadoc. This forces users to read 
> source code or sample code to understand what their arguments stand for or 
> how one is difference from the others.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to