[
https://issues.apache.org/jira/browse/ZOOKEEPER-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044455#comment-14044455
]
Rakesh R commented on ZOOKEEPER-1851:
-------------------------------------
Hi Chris Chen,
Nice test cases.
Just few comments to improve 'QuorumRequestPipelineTest.java' test class.
# Please add Apache License Header to it.
# Indent should be four spaces per level, presently its with two spaces. Please
refer
[HowToContribute|https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute]
# Please use bigger value (30secs ?) allComplete.await(1, TimeUnit.SECONDS); to
make it more reliable. If the h/w is slow still give the test a chance to pass.
# Suggestion, please modify the HashSet usage by making it generic type
HashSet<String>
> Follower and Observer Request Processors Do Not Forward create2 Requests
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1851
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1851
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.5.0
> Reporter: Chris Chen
> Assignee: Thawan Kooburat
> Labels: patch
> Attachments: ZOOKEEPER-1851.patch, ZOOKEEPER-1851.patch
>
>
> Recent changes to the Observer and Follower Request Processors switch on the
> request opcode, but create2 is left out. This leads to a condition where the
> create2 request is passed to the CommitProcessor, but the leader never gets
> the request, the CommitProcessor can't find a matching request, so the client
> gets disconnected.
> Added tests as well.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
