[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079760#comment-14079760
 ] 

Alexander Shraer commented on ZOOKEEPER-1992:
---------------------------------------------

Here's my proposal, can you clarify which part you feel uncomfortable with ?

- in QuorumPeer.writeDynamicConfig, pass a new parameter that indicates that 
you need to delete clientPort and clientPortAddress from the static file (last 
configuration didn't includes a client port for self.getId() but the new one 
has it, you can know that from where you call this function, in 
QuorumPeer.setQuorumVerifier).

- in QuorumPeerConfig, where this exception is thrown 
throw new ConfigException("client address for this server (id = " + serverId + 
") in static config file is " + clientPortAddress + " is different from client 
address found in dynamic file: " + qs.clientAddr);
                   
and an "else" (meaning "everything is consistent) that in case clientPort and 
clientPortAddress appear in the dynamic file removes them from the static file. 


> backward compatibility of zoo.cfg
> ---------------------------------
>
>                 Key: ZOOKEEPER-1992
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1992
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Blocker
>             Fix For: 3.5.0
>
>
> This issue supersedes our discussion in ZOOKEEPER-1989.
> To summarize, ZK users can seamlessly upgrade 3.4 to 3.5. But two things will 
> happen:
> 1. the server list will be separated out as a dynamic file (the original 
> should be backup automatically).
> 2. Client port is mandatory on reconfig. So when reconfig the server itself 
> (its id), the client port in config file will be removed and replaced by the 
> one in reconfig (written in dynamic file).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to