[
https://issues.apache.org/jira/browse/ZOOKEEPER-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079962#comment-14079962
]
Alexander Shraer commented on ZOOKEEPER-1992:
---------------------------------------------
yes, that's correct.
the logic here seems wrong - some of the && should be || etc... a key can't
both start with server. and with group.
+ if ((backwardCompatible
+ && key.startsWith("server.") &&
key.startsWith("group")
+ && key.startsWith("weight"))
+ ||
+ (eraseClient
+ && key.equals("clientPort") &&
key.equals("clientPortAddress"))) {
+ continue;
if (!key.startsWith("server.") && !key.startsWith("group") &&
!key.startsWith("weight")
&& (!eraseClient || ( !key.equals("clientPort") &&
!key.equals("clientPortAddress"))){
out.write(key.concat("=").concat(value).concat("\n"));
> backward compatibility of zoo.cfg
> ---------------------------------
>
> Key: ZOOKEEPER-1992
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1992
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: draft-2.patch, draft.patch
>
>
> This issue supersedes our discussion in ZOOKEEPER-1989.
> To summarize, ZK users can seamlessly upgrade 3.4 to 3.5. But two things will
> happen:
> 1. the server list will be separated out as a dynamic file (the original
> should be backup automatically).
> 2. Client port is mandatory on reconfig. So when reconfig the server itself
> (its id), the client port in config file will be removed and replaced by the
> one in reconfig (written in dynamic file).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
