[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113657#comment-14113657
 ] 

Rakesh R commented on ZOOKEEPER-1948:
-------------------------------------

Thanks [~gsbiju] for the patch. I've few comments, please see.
# Please modify "xJMXSSL" to "x$JMXSSL"
{code}
if [ "xJMXSSL" = "x" ]
{code}
# Any reason to disable zookeeper.jmx.log4j.disable=true?
# Minor suggestion - move the following echo msg above to if [ "x$JMXPORT" = 
"x" ] statement, just to avoid duplicates
{code}
echo "ZooKeeper JMX enabled by default" >&2
{code}

> Enable JMX remote monitoring - Updated patch for review comments
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1948
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1948
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.6
>         Environment: All
>            Reporter: Biju Nair
>            Assignee: Biju Nair
>             Fix For: 3.4.7, 3.5.1
>
>         Attachments: ZOOKEEPER-1948.patch, zookeeper-1948.patch
>
>
> The zooker server start up script includes the option to enable jmx 
> monitoring but only locally. Can we update the script so that remote 
> monitoring can also be enabled which will help in data collection and 
> monitoring through a centralized monitoring tool.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to