[
https://issues.apache.org/jira/browse/ZOOKEEPER-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117094#comment-14117094
]
Rakesh R commented on ZOOKEEPER-1948:
-------------------------------------
Thanks [~gsbiju], it looks better. I prefer to use "ZooKeeper" instead of small
letter "Zookeeper" in the echo messages. Sorry to include this in my previous
review.
{code}
+ echo "Zookeeper remote JMX ssl set to $JMXSSL" >&2
+ echo "Zookeeper remote JMX log4j set to $JMXLOG4J" >&2
{code}
Secondly, IMHO good to create patch with the JIRA name itself like
'ZOOKEEPER-1948.patch'. Also, press 'Submit Patch' button once the patch is
ready to go for review and commit. This will be helpful for the reviewers.
> Enable JMX remote monitoring - Updated patch for review comments
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-1948
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1948
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.6
> Environment: All
> Reporter: Biju Nair
> Assignee: Biju Nair
> Fix For: 3.4.7, 3.5.1
>
> Attachments: ZOOKEEPER-1948.patch, ZOOKEEPER-1948.patch.v2,
> zookeeper-1948.patch
>
>
> The zooker server start up script includes the option to enable jmx
> monitoring but only locally. Can we update the script so that remote
> monitoring can also be enabled which will help in data collection and
> monitoring through a centralized monitoring tool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
