[ https://issues.apache.org/jira/browse/ZOOKEEPER-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136196#comment-14136196 ]
Hadoop QA commented on ZOOKEEPER-2016: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12669170/ZOOKEEPER-2016.patch against trunk revision 1623916. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2342//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2342//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2342//console This message is automatically generated. > Automate client-side rebalancing > -------------------------------- > > Key: ZOOKEEPER-2016 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2016 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Hongchao Deng > Assignee: Hongchao Deng > Attachments: ZOOKEEPER-2016.patch, draft-2.patch, draft-3.patch, > draft.patch > > > ZOOKEEPER-1355 introduced client-side rebalancing, which is implemented in > both the C and Java client libraries. However, it requires the client to > detect a configuration change and call updateServerList with the new > connection string (see reconfig manual). It may be better if the client just > indicates that he is interested in this feature when creating a ZK handle and > we'll detect configuration changes and invoke updateServerList for him > underneath the hood. > Reviewboard: https://reviews.apache.org/r/25599/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)