[ https://issues.apache.org/jira/browse/ZOOKEEPER-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141091#comment-14141091 ]
Alexander Shraer commented on ZOOKEEPER-2016: --------------------------------------------- Good point. But do you think it matters ? in your case you have a separate thread that is responsible for updateServerList, is it bad that it will do the waiting before calling ? We could consider passing an optional callback function to updateServerList that would execute before disconnecting, or alternatively split updateServerList it into two functions - the first updates the list and optionally rebalances (by default) and the other one that only rebalances so that you could call something in between those two. But again I'm not convinced yet that its needed. > Automate client-side rebalancing > -------------------------------- > > Key: ZOOKEEPER-2016 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2016 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Hongchao Deng > Assignee: Hongchao Deng > Attachments: draft-2.patch, draft-3.patch, draft-4.patch, draft.patch > > > ZOOKEEPER-1355 introduced client-side rebalancing, which is implemented in > both the C and Java client libraries. However, it requires the client to > detect a configuration change and call updateServerList with the new > connection string (see reconfig manual). It may be better if the client just > indicates that he is interested in this feature when creating a ZK handle and > we'll detect configuration changes and invoke updateServerList for him > underneath the hood. > Reviewboard: https://reviews.apache.org/r/25599/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)