[ https://issues.apache.org/jira/browse/ZOOKEEPER-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144389#comment-14144389 ]
Alexander Shraer commented on ZOOKEEPER-2031: --------------------------------------------- Hi, I like the idea of having a tag, but have some questions/concerns. I went over the reviewboard, and sent some preliminary comments, but would like to go over it a bit more carefully when I have more time. 1) when is the tag assigned to a server ? suppose I'm adding server 2 using and specifying a certain tag in the reconfig command. It seems that 2 will be added, no matter what its tag was booting up. Right ? 2) Kindof related to 1 - can tag be modified dynamically ? what happens if I invoke a reconfig specifying a different tag for server 2 ? 3) are any CLI changes required ? how about C ? 4) I'm a bit concerned of having an arbitrary string as the suffix of the server string. It may mean that we'll never be able to add anything else there. Would it be better to have tag as a separate keyword ? Like tag.1 = ... or something like that. Basically I suspect that this patch has more implications than I currently understand, that's why I'm hesitant :) Alex > Support tagging a QuorumServer > ------------------------------ > > Key: ZOOKEEPER-2031 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2031 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: some one > Assignee: some one > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2031-Additional.patch, ZOOKEEPER-2031.patch > > > Currently ZooKeeper only allows using the server id which is an integer for > identifying servers. For my (unavoidable) use case, there may be concurrent > dynamic removes and adds of servers which may eventually have id collisions. > When this occurs, there is no good way to determine if the server (given an > id collision) that we want to remove is the right server. > To support my use case, I propose that we add a tag field to the server > string. > For my specific use case, this tag field will be used to store a uuid as a > string. > So for example: > server.1=127.0.0.1:1234:1236:participant;0.0.0.0:1237;743b9d23-85cb-45b1-8949-930fdabb21f0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)