[ https://issues.apache.org/jira/browse/ZOOKEEPER-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145677#comment-14145677 ]
some one commented on ZOOKEEPER-2031: ------------------------------------- > 1 and 2 I've just written the tests for those and will be uploading a new patch with it soon. > 3. checking consistent dynamic config file (with tags) over reconfig. I'm not sure what you mean by this test case? The patch does not modify reconfig to make sure that the tags match, because it is up to the user to look at the version of the config and pass that along with the reconfig command to ensure that they are removing the correct server. Meaning if a user gets the following config: <config 1> server.1=....;someTag1 server.2=....;someTag2 version=1 And then they verify that someTag2 is the correct tag corresponding to server.2, then they would perform a reconfig as follows: reconfig -v 1 -remove 2 If the config has changed in the meantime, then the reconfig operation will fail. There is no test needed by me to verify this, because this is just an intrinsic part of the reconfig command itself. > Support tagging a QuorumServer > ------------------------------ > > Key: ZOOKEEPER-2031 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2031 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: some one > Assignee: some one > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2031-Additional.patch, ZOOKEEPER-2031.patch > > > Currently ZooKeeper only allows using the server id which is an integer for > identifying servers. For my (unavoidable) use case, there may be concurrent > dynamic removes and adds of servers which may eventually have id collisions. > When this occurs, there is no good way to determine if the server (given an > id collision) that we want to remove is the right server. > To support my use case, I propose that we add a tag field to the server > string. > For my specific use case, this tag field will be used to store a uuid as a > string. > So for example: > server.1=127.0.0.1:1234:1236:participant;0.0.0.0:1237;743b9d23-85cb-45b1-8949-930fdabb21f0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)