[jira] [Commented] (ZOOKEEPER-2062) RemoveWatchesTest takes forever to run

[Rakesh R (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171846#comment-14171846
 ] 

Rakesh R commented on ZOOKEEPER-2062:
-------------------------------------

Thanks @fpj for pointing out this. Following are the testcases which takes huge 
amount of time. Most of them have verification points by checking that the 
watcher(data/child) is really removed or not, its done by waiting few 
seconds(CONNECTION_TIMEOUT/5) for the watch notifications. This certainly needs 
improvement and can think for a better verification idea.

{code}
RemoveWatchesTest.java
       Assert.assertFalse("Shouldn't remove data watcher", w1.matches());

       // matches logic is waiting for the watch notification ?
        public boolean matches() throws InterruptedException {
            if (!latch.await(CONNECTION_TIMEOUT/5, TimeUnit.MILLISECONDS)) {
                LOG.error("Failed waiting to remove the watches");
                return false;
            }
{code}

{code}
testRemoveAllChildWatchesOnAPath[0]     30 sec  Passed
testRemoveAllChildWatchesOnAPath[1]     30 sec  Passed
testRemoveAllDataWatchesOnAPath[0]      30 sec  Passed
testRemoveAllDataWatchesOnAPath[1]      30 sec  Passed
testRemoveWatcherWhenNoConnection[0]    14 sec  Passed
testRemoveWatcherWhenNoConnection[1]    14 sec  Passed
testMultipleChildWatchers[0]            9 sec   Passed
testMultipleChildWatchers[1]            9 sec   Passed
testManyWatchersWhenNoConnection[1]     6.9 sec Passed
testChRootRemoveWatcher[0]              6.1 sec Passed
testChRootRemoveWatcher[1]              6 sec   Passed
testMultipleDataWatchers[0]             6 sec   Passed
testMultipleDataWatchers[1]             6 sec   Passed
testRemoveAnyChildWatcher[0]            6 sec   Passed
testRemoveAnyChildWatcher[1]            6 sec   Passed
testRemoveAnyDataWatcher[0]             6 sec   Passed
testRemoveAnyDataWatcher[1]             6 sec   Passed
testRemoveSingleWatcher[0]              6.4 sec Passed
testRemoveSingleWatcher[1]              6 sec   Passed
testManyWatchersWhenNoConnection[0]     5.2 sec Passed
{code}

> RemoveWatchesTest takes forever to run
> --------------------------------------
>
>                 Key: ZOOKEEPER-2062
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2062
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Flavio Junqueira
>
> [junit] Running org.apache.zookeeper.RemoveWatchesTest
>     [junit] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 306.188 sec



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)