[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303006#comment-14303006 ]
Hadoop QA commented on ZOOKEEPER-1907: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696120/ZOOKEEPER-1907.patch against trunk revision 1656167. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2504//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2504//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2504//console This message is automatically generated. > Improve Thread handling > ----------------------- > > Key: ZOOKEEPER-1907 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.5.0 > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, > ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, > ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, > ZOOKEEPER-1907.patch > > > Server has many critical threads running and co-ordinating each other like > RequestProcessor chains et. When going through each threads, most of them > having the similar structure like: > {code} > public void run() { > try { > while(running) > // processing logic > } > } catch (InterruptedException e) { > LOG.error("Unexpected interruption", e); > } catch (Exception e) { > LOG.error("Unexpected exception", e); > } > LOG.info("...exited loop!"); > } > {code} > From the design I could see, there could be a chance of silently leaving the > thread by swallowing the exception. If this happens in the production, the > server would get hanged forever and would not be able to deliver its role. > Now its hard for the management tool to detect this. > The idea of this JIRA is to discuss and imprv. > Reference: [Community discussion > thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E] -- This message was sent by Atlassian JIRA (v6.3.4#6332)