[jira] [Commented] (ZOOKEEPER-2171) avoid reverse lookups in QuorumCnxManager

[Raul Gutierrez Segales (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520571#comment-14520571
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2171:
---------------------------------------------------

Hmm, ant test-core-java passes locally for me but we get this in CI:

{noformat}
Error Message

Address already in use

Stacktrace

java.net.BindException: Address already in use
        at sun.nio.ch.Net.bind0(Native Method)
        at sun.nio.ch.Net.bind(Net.java:344)
        at sun.nio.ch.Net.bind(Net.java:336)
        at 
sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
        at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
        at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
        at 
org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:687)
        at 
org.apache.zookeeper.server.ServerCnxnFactory.configure(ServerCnxnFactory.java:75)
        at 
org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:152)
        at 
org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:145)
        at 
org.apache.zookeeper.test.ACLCountTest.testAclCount(ACLCountTest.java:73)
        at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
{noformat}

I'll have it run one more time. 

> avoid reverse lookups in QuorumCnxManager
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2171
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2171
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch
>
>
> Apparently, ZOOKEEPER-107 (via a quick git-blame look) introduced a bunch of 
> getHostName() calls in QCM. Besides the overhead, these can cause problems 
> when mixed with failing/mis-configured DNS servers.
> It would be nice to reduce them, if that doesn't affect operational 
> correctness. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)