[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525928#comment-14525928
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2171:
---------------------------------------------------

Thanks for the review [~rakeshr]. Though the getHostName calls in the 
LeaderElection recipe are not InetSocketAddress#getHostName calls:

https://github.com/apache/zookeeper/blob/trunk/src/recipes/election/src/java/org/apache/zookeeper/recipes/leader/LeaderOffer.java#L63

Yeah, I'll cleanup the calls in those tests as well. 

> avoid reverse lookups in QuorumCnxManager
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2171
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2171
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch, 
> ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch
>
>
> Apparently, ZOOKEEPER-107 (via a quick git-blame look) introduced a bunch of 
> getHostName() calls in QCM. Besides the overhead, these can cause problems 
> when mixed with failing/mis-configured DNS servers.
> It would be nice to reduce them, if that doesn't affect operational 
> correctness. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to