----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review82648 -----------------------------------------------------------
CHANGES.txt <https://reviews.apache.org/r/33713/#comment133418> This is not required, please revert this changes bin/zkServer.sh <https://reviews.apache.org/r/33713/#comment133419> This is not required, please revert this changes src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/33713/#comment133438> Minor suggestion: I could see many places the import statements has been modified to .* I prefer not to change the existing imports it may show many changes in diff that may deviate reviewers focus. We can do import the necessary classess/items required for the implementation. src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/33713/#comment133420> I assume you are referring to jute.maxbuffer. It is not good to hard code value 1MB, right? src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/33713/#comment133437> One general thought: Instead of providing a new API for creating the container, can we think of "CreateMode.CONTAINER" a new znode type? Also, I feel this may help us to support multiTxn/batch apis. I haven't done detailed analysis, this is just a rough thought that comes in my mind. src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/33713/#comment133421> I assume you are referring to jute.maxbuffer. It is not good to hard code value 1MB, right? src/java/main/org/apache/zookeeper/server/ContainerManager.java <https://reviews.apache.org/r/33713/#comment133422> Please replace System.currentMillis() with org.apache.zookeeper.common.Time.currentElapsedTime() src/java/main/org/apache/zookeeper/server/ContainerManager.java <https://reviews.apache.org/r/33713/#comment133423> Please use {} instead of + for string concatenation in logs src/java/main/org/apache/zookeeper/server/ContainerManager.java <https://reviews.apache.org/r/33713/#comment133424> Please use {} instead of + for string concatenation in logs src/java/main/org/apache/zookeeper/server/ContainerManager.java <https://reviews.apache.org/r/33713/#comment133425> Can we modify System.currentTimeMillis() using org.apache.zookeeper.common.Time ? src/java/main/org/apache/zookeeper/server/ContainerManager.java <https://reviews.apache.org/r/33713/#comment133426> Please format this line, its more than >80 chars src/java/main/org/apache/zookeeper/server/ContainerManager.java <https://reviews.apache.org/r/33713/#comment133428> Could you please tell me the reson for the checks node.stat.getCversion() > 0 ? Probably you can add a comment over there, so that others also will understand. src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/33713/#comment133431> Please modify string concatenation in logs using {} src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/33713/#comment133432> Could you tell me the behaviour if there occurs NoNodeException? src/java/test/org/apache/zookeeper/server/CreateContainerTest.java <https://reviews.apache.org/r/33713/#comment133434> Please add timeout args in tests like, @Test(timeout=60000) src/java/test/org/apache/zookeeper/server/CreateContainerTest.java <https://reviews.apache.org/r/33713/#comment133435> Can we think of some better logic instead of Thread.sleep(1000) in tests. It may be flaky in some env, right? src/java/test/org/apache/zookeeper/server/CreateContainerTest.java <https://reviews.apache.org/r/33713/#comment133436> Can we think of some better logic instead of Thread.sleep(1000) in tests. It may be flaky in some env, right? I could see there are few more occurances of Thread.sleep(xx) similar to this, please do the changes. Thanks! - Rakesh R On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33713/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 4:08 p.m.) > > > Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-2163 > https://issues.apache.org/jira/browse/ZOOKEEPER-2163 > > > Repository: zookeeper-git > > > Description > ------- > > Introduce new ZNode type: container > > > Diffs > ----- > > CHANGES.txt 51ec65d > bin/zkServer.sh dae3ce2 > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca > src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e > src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 > src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 > src/java/main/org/apache/zookeeper/server/ContainerManager.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 > src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 > src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 7e3c29f > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf > src/java/main/org/apache/zookeeper/server/Request.java bed9b13 > src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d > src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 > src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > cf0900b > > src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 4d061f4 > src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java > 6434d02 > > src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 36a23ee > > src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > a49319c > src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e > src/java/test/org/apache/zookeeper/server/CreateContainerTest.java > PRE-CREATION > src/zookeeper.jute 709e935 > > Diff: https://reviews.apache.org/r/33713/diff/ > > > Testing > ------- > > > Thanks, > > Jordan Zimmerman > >
