> On May 6, 2015, 9:22 a.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ZooKeeper.java, line 34 > > <https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line34> > > > > Minor suggestion: > > I could see many places the import statements has been modified to .* > > > > I prefer not to change the existing imports it may show many changes in > > diff that may deviate reviewers focus. We can do import the necessary > > classess/items required for the implementation.
Sorry - IntelliJ does this automatically. I'll try to revert these. > On May 6, 2015, 9:22 a.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1392 > > <https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1392> > > > > I assume you are referring to jute.maxbuffer. It is not good to hard > > code value 1MB, right? I copied this doc verbatim from the create() method. It seems to me that this should be globally changed in a separate issue. > On May 6, 2015, 9:22 a.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1433 > > <https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1433> > > > > I assume you are referring to jute.maxbuffer. It is not good to hard > > code value 1MB, right? I copied this doc verbatim from the create() method. It seems to me that this should be globally changed in a separate issue. - Jordan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review82648 ----------------------------------------------------------- On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33713/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 4:08 p.m.) > > > Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-2163 > https://issues.apache.org/jira/browse/ZOOKEEPER-2163 > > > Repository: zookeeper-git > > > Description > ------- > > Introduce new ZNode type: container > > > Diffs > ----- > > CHANGES.txt 51ec65d > bin/zkServer.sh dae3ce2 > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca > src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e > src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 > src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 > src/java/main/org/apache/zookeeper/server/ContainerManager.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 > src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 > src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 7e3c29f > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf > src/java/main/org/apache/zookeeper/server/Request.java bed9b13 > src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d > src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 > src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > cf0900b > > src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 4d061f4 > src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java > 6434d02 > > src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 36a23ee > > src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > a49319c > src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e > src/java/test/org/apache/zookeeper/server/CreateContainerTest.java > PRE-CREATION > src/zookeeper.jute 709e935 > > Diff: https://reviews.apache.org/r/33713/diff/ > > > Testing > ------- > > > Thanks, > > Jordan Zimmerman > >
