[
https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544907#comment-14544907
]
Raul Gutierrez Segales commented on ZOOKEEPER-602:
--------------------------------------------------
+1, thanks for backporting this [~rakeshr] (i re-read the patch, although i had
reviewed it for trunk as well).
one note though (applicable to trunk as well):
in ZooKeeperThread#handleException:
{code}
protected void handleException(String thName, Throwable e) {
LOG.warn("Exception occured from thread {}", thName, e);
}
{code}
i think that should be LOG.error, given it's unhandled. what do you think?
happy to merge this, unless someone else wants to have another look (cc:
[~phunt], [~hdeng]).
> log all exceptions not caught by ZK threads
> -------------------------------------------
>
> Key: ZOOKEEPER-602
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client, server
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-602-br3-4.patch, ZOOKEEPER-602.patch,
> ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch,
> ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch
>
>
> the java code should add a ThreadGroup exception handler that logs at ERROR
> level any uncaught exceptions thrown by Thread run methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
